Use setuptools and its entry_points option to avoid --command-packag… #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s=stdeb.command. However, this requires setuptools (which was removed in 2009).
dirk-thomas
reviewed
Dec 4, 2019
| @@ -1,4 +1,4 @@ | |||
| from distutils.core import setup | |||
| from setuptools import setup | |||
There was a problem hiding this comment.
The switch to setuptools seems quite significant to me. I am not sure I can reasonably test this in all possible scenarios to ensure it doesn't break anything.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…es=stdeb.command.
However, this requires setuptools (which was removed in 2009).
I do not know why it has been removed, and if these reasons are valid six years later, so I offer this pull request.