Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test astropy-helpers v0.4.8 release against astropy #3555

Merged
merged 1 commit into from Mar 4, 2015

Conversation

embray
Copy link
Member

@embray embray commented Feb 27, 2015

No milestone for this unless later there is a need to release a new v0.4.x version for Astropy.

@embray embray added the 💤 astropy-helpers PRs and issues related to astropy-helpers label Feb 27, 2015
@embray
Copy link
Member Author

embray commented Feb 27, 2015

sigh apparently the import of matplotlib causes havoc in the docs build :\

@embray
Copy link
Member Author

embray commented Feb 27, 2015

Updated to a new version that I think might work around the docs build issue.

@embray
Copy link
Member Author

embray commented Feb 27, 2015

sigh nope, somehow that didn't fix it. I'll probably have to wait 'til Monday to resolve this.

@embray
Copy link
Member Author

embray commented Mar 3, 2015

Giving this yet another try, finally I took a look at the plot directive sphinxext to see what it does. Seems like just setting matplotlib.use('Agg') should get around this. I don't see any reason any package should want to use any other matplotlib backend during installation. @mdboom ?

@astrofrog
Copy link
Member

@embray - just out of curiosity, what was the error before?

@embray
Copy link
Member Author

embray commented Mar 3, 2015

Trying to import matplotlib (or probably more specifically matplotlibpyplot) was causing the documentation build to blow up since it was trying to use the Qt backend :(

@mdboom
Copy link
Contributor

mdboom commented Mar 3, 2015

Yes -- forcibly setting the Agg backend during installation seems fine.

@embray
Copy link
Member Author

embray commented Mar 3, 2015

This is all just to get around matplotlib/matplotlib#4165. Fortunately this is an obscure case. It sucks but I don't see any other way right now (and fortunately ISTM importing matplotlib doesn't really add much overhead).

@embray
Copy link
Member Author

embray commented Mar 4, 2015

whew Well that seems to have done the trick. I can release this and v1.0.1 later today.

embray added a commit that referenced this pull request Mar 4, 2015
Test astropy-helpers v0.4.8 release against astropy
@embray embray merged commit fb3ef6d into astropy:v0.4.x Mar 4, 2015
@embray embray deleted the release-ah-0.4.8 branch March 4, 2015 16:30
@embray
Copy link
Member Author

embray commented Mar 4, 2015

Oops. I just realized this failed to include the ah_boostrap script which was somewhat important in this case. I will just make a new PR :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💤 astropy-helpers PRs and issues related to astropy-helpers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants