Removed URC echo matching #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marius-meissner
force-pushed
the
urc_echo_consuming
branch
2 times, most recently
from
4957992
to
f53f4e5
Compare
marius-meissner
force-pushed
the
urc_echo_consuming
branch
from
f53f4e5
to
cc1575c
Compare
|
@nbarrios Feel free to have a brief look and add feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #13 consuming of echo messages in URC is causing issues.
For example, the first IPv4 address of get_address() is lost.
In this PR, the derive implementation of
ObtainLocalAddressCommandwas also replaced, since it generated invalid binaries for thumbv6m for reasons still unknown. The problem seems to be related to heapless String.