Synchronous socket #34
Conversation
jmercouris
force-pushed
the
synchronous-socket
branch
from
8bccacf
to
b6530fa
Compare
There was a problem hiding this comment.
I understand the ideas behind the changes but I think it requires some polishing.
Commit b6530fa seems unrelated to this PR so I'd suggest moving it into a separate one.
Keep in mind the length of the summary commit message.
I've tested this branch on macOS, rebased on top of #35, and the electron-window-demo doesn't seem to be working as intended. Note that at this point, all work must be test on macOS too.
|
I will be testing on macOS tomorrow to ensure that this works properly. I will also rebase and tweak #35 as necessary in conjunction with this pull request. |
jmercouris
force-pushed
the
synchronous-socket
branch
2 times, most recently
from
203b935
to
abf141b
Compare
|
Works on macOS! Now, I do have a branch that updates Nyxt to work with this latest set of changes. We'll have to update the submodule for cl-electron when we merge that branch. |
Additionally, fix library path for cl-electron.
Create a class that uses execFileSync to synchronously read information from a socket. execFileSync calls query.js with some data. query.js will write this data to the socket and read the response. query.js will then spit out this data to stdout, from where it can be read by execFileSync. Inspired by the Node.js sync-socket library. server.js: Optionally specify a timeout. Allow dynamic definition of the query.js script path. This is useful for when server.js is moved to a tmp file for the creation of protocols. The SynchronousSocket class must be able to have a path to the module to execute it.
loop-connect-p predicate. This predicate is useful for things like the SynchronousSocket. After the process dies, we need the passive (listening) socket from Lisp to keep accepting new connections. Thus, we need to loop iolib:with-accept-connection to maintain a channel for new SynchronousSocket requests.
control. With this new interface, register-before-input-event allows the Lisp side of cl-electron to control whether event.preventDefault() will be invoked, and thus whether an event WILL/WILL NOT propagate throughout the renderer. For example, if we want to intercept C-a in Lisp, we can return "t" from our callback in register-before-input-event, and we'll be able to avoid C-a being handled by the renderer.
Demonstrate the bubble handling control of the new register-before-input-event function.
Additionally, create `(message ((remote-object remote-object)) ...)` to avoid having to write `(message (interface x) ...)` everywhere in the codebase.
Allow the user to interactively handle cases where the socket/interface already exists.
jmercouris
force-pushed
the
synchronous-socket
branch
from
abf141b
to
ef17261
Compare
|
The follow-up pull request is here: atlas-engineer/nyxt#3381 |
|
Please also note that I will be working on a version of this change set that uses a C extension for Node.js to do synchronous socket reads rather than our sync-socket method. However, this does unblock us to do proper input handling! |
This adds A LOT of functionality to
cl-electron. It particularly makes it possible for us to do flow-control within input events.Note, there are not that many changes, there is only one large change that renames
send-message-interface.