-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install `cl-electron' via NPM. Use standard build-tools. #43
Conversation
93bc0c8
to
95f5fa4
Compare
Will review as soon as I'll setup Ubuntu, thanks. |
These components are not used in the project.
95f5fa4
to
785c9af
Compare
Thanks for working on this PR @jmercouris. I took over and fixed some minor things. I've tested the setup on macOS (relying on Nix for the CL dependencies) and Linux (Ubuntu, relying on Guix for the CL dependencies). For reference, here's how I set (cl-electron-guix
("guix" "shell" "-m" "manifest.scm" "--" "sbcl")
;; To use the Guix Lisp dependencies versions, comment the env below.
:env ("CL_SOURCE_REGISTRY=~/common-lisp//:~/common-lisp/nyxt/_build//"
"LD_LIBRARY_PATH=/gnu/store/<hash>-libfixposix-0.4.3/lib")
:directory "~/common-lisp/cl-electron/")
(cl-electron-nix
("nix-shell" "--run" "sbcl --dynamic-space-size 3072")
:env ("CL_SOURCE_REGISTRY=~/common-lisp//:~/common-lisp/nyxt/_build//")
:directory "~/common-lisp/cl-electron/") Tests and examples seem to run smoothly on the platforms mentioned above. I'd like run the checks mentioned above again in a clean environment (by removing the CL and Node.JS cache). Also, I'm taking over atlas-engineer/nyxt#3381 and I'd like to merge these 2 PRs at once. I.e., I'll work on atlas-engineer/nyxt#3381 with the state of this PR, check whether everything's OK, and merge both. |
785c9af
to
5fee8b7
Compare
This installation system will work on a standard Linux/macOS system. Additionally, add support for `synchronous-socket' via package.json.
There may be dangling processes without the fix.
NPM install synchronous-socket locally (in the project's folder), but server-path may not be located there. See the handling of server-path and protocols and note that server-path may be a tmp file.
Only handles the CL environment.
Only handles the CL environment.
5fee8b7
to
de73c64
Compare
Thanks @jmercouris! |
thank you! |
This is a standard installation method that should work on Ubuntu and other conforming operating systems including macOS.
This is a draft. I am still considering removing the usage of NPX and referencing the Electron binary via an absolute path.