Skip to content

Commit

Permalink
Fixed comparisons to avoid overflow. (cms-sw#128)
Browse files Browse the repository at this point in the history
  • Loading branch information
aehart committed Feb 8, 2022
1 parent 13f80ef commit 9c2f365
Showing 1 changed file with 3 additions and 3 deletions.
Expand Up @@ -691,7 +691,7 @@ bool TrackletCalculatorDisplaced::LLLSeeding(const Stub* innerFPGAStub,
continue;

//check r projection in range
if (rprojdiskapprox[i] < settings_.rmindisk() || rprojdiskapprox[i] > settings_.rmaxdisk())
if (rprojdiskapprox[i] < settings_.rmindisk() || rprojdiskapprox[i] >= settings_.rmaxdisk())
continue;

projs[N_LAYER + i].init(settings_,
Expand Down Expand Up @@ -1097,7 +1097,7 @@ bool TrackletCalculatorDisplaced::DDLSeeding(const Stub* innerFPGAStub,
if (iphiprojdisk[i] >= (1 << settings_.nphibitsstub(0)) - 1)
continue;

if (irprojdisk[i] < settings_.rmindisk() / krprojdisk || irprojdisk[i] > settings_.rmaxdisk() / krprojdisk)
if (irprojdisk[i] < settings_.rmindisk() / krprojdisk || irprojdisk[i] >= settings_.rmaxdisk() / krprojdisk)
continue;

projs[N_LAYER + i + 2].init(settings_,
Expand Down Expand Up @@ -1494,7 +1494,7 @@ bool TrackletCalculatorDisplaced::LLDSeeding(const Stub* innerFPGAStub,
continue;

//Check r range of projection
if (irprojdisk[i] < settings_.rmindisk() / krprojdisk || irprojdisk[i] > settings_.rmaxdisk() / krprojdisk)
if (irprojdisk[i] < settings_.rmindisk() / krprojdisk || irprojdisk[i] >= settings_.rmaxdisk() / krprojdisk)
continue;

projs[N_LAYER + i + 1].init(settings_,
Expand Down

0 comments on commit 9c2f365

Please sign in to comment.