fix(array-observation): handle push then sort

Flush any existing changeRecords prior to enqueuing a collection reset Fixes #233
aurelia · Dec 7, 2015 · 2ae6d0e · 2ae6d0e
1 parent 83f0f53
commit 2ae6d0e
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/src/array-observation.js b/src/array-observation.js
@@ -40,6 +40,7 @@ class ModifyArrayObserver extends ModifyCollectionObserver {
     }
 
     array['reverse'] = function(){
+      observer.flushChangeRecords();
       var oldArray = array.slice();
       var methodCallResult = arrayProto['reverse'].apply(array, arguments);
       observer.reset(oldArray);
@@ -58,6 +59,7 @@ class ModifyArrayObserver extends ModifyCollectionObserver {
     };
 
     array['sort'] = function() {
+      observer.flushChangeRecords();
       var oldArray = array.slice();
       var methodCallResult = arrayProto['sort'].apply(array, arguments);
       observer.reset(oldArray);

diff --git a/src/collection-observation.js b/src/collection-observation.js
@@ -52,6 +52,12 @@ export class ModifyCollectionObserver {
     }
   }
 
+  flushChangeRecords() {
+    if ((this.changeRecords && this.changeRecords.length) || this.oldCollection) {
+      this.call();
+    }
+  }
+
   reset(oldCollection) {
     this.oldCollection = oldCollection;