fix(observer): respect non-enumerable properties

aurelia · May 16, 2016 · ff8f9c7 · ff8f9c7
1 parent bb40575
commit ff8f9c7
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/src/property-observation.js b/src/property-observation.js
@@ -96,7 +96,8 @@ export class SetterObserver {
 
     if (!Reflect.defineProperty(this.obj, this.propertyName, {
       configurable: true,
-      enumerable: true,
+      enumerable: this.propertyName in this.obj ?
+          this.obj.propertyIsEnumerable(this.propertyName) : true,
       get: this.getValue.bind(this),
       set: this.setValue.bind(this)
     })) {

diff --git a/test/observer-locator.spec.js b/test/observer-locator.spec.js
@@ -53,6 +53,24 @@ describe('ObserverLocator', () => {
     expect(Logger.prototype.warn).toHaveBeenCalledWith('Cannot observe property \'bar\' of object', obj);
   });
 
+  it('respects the enumerability in the SetterObserver', () => {
+    var obj = {};
+    Object.defineProperties(obj, {
+      'foo': {
+        configurable: true,
+        enumerable: true
+      },
+      'bar': {
+        configurable: true,
+        enumerable: false
+      }
+    });
+    ['foo', 'bar', 'baz'].forEach(prop => {
+      locator.getObserver(obj, prop).convertProperty();
+    });
+    expect(Object.keys(obj)).toEqual(['foo', 'baz']);
+  });
+
   it('uses ValueAttributeObserver for element value attributes', () => {
     var obj = createElement('<input />'),
         observer = locator.getObserver(obj, 'value');