Skip to content

Commit

Permalink
fix(Repeat): ignore changes after unsubscribe
Browse files Browse the repository at this point in the history
  • Loading branch information
jdanyow committed Apr 14, 2016
1 parent 2d4ccc5 commit 96b721f
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions src/repeat.js
Expand Up @@ -148,13 +148,19 @@ export class Repeat extends AbstractRepeater {
* Invoked when the underlying collection changes.
*/
handleCollectionMutated(collection, changes) {
if (!this.collectionObserver) {
return;
}
this.strategy.instanceMutated(this, collection, changes);
}

/**
* Invoked when the underlying inner collection changes.
*/
handleInnerCollectionMutated(collection, changes) {
if (!this.collectionObserver) {
return;
}
// guard against source expressions that have observable side-effects that could
// cause an infinite loop- eg a value converter that mutates the source array.
if (this.ignoreMutation) {
Expand Down

0 comments on commit 96b721f

Please sign in to comment.