Rss feed #1343
Rss feed #1343
Conversation
|
Once you get this one merged, if you merge. I will use this as a base for the sitemap.xml issue #1336. |
|
I would like to request you to please close this PR. |
| @foreach($posts as $post) | ||
| <item> | ||
| <title><![CDATA[{{ $post->title }}]]></title> | ||
| <link>{{ url($post->slug) }}</link> |
There was a problem hiding this comment.
Passing in the post slug is good, but we should be using the absolute path to the post - which can vary. Depending if someone wants their publication at: /blog, or /news, etc.
You could try to use this config value, but there could still be edge cases.
There was a problem hiding this comment.
we can have two approaches.
- we can ask the user to add the static path of the post in the config.
- we can make the feed view publishable, so if the user has a custom url he can configure the feed accordingly.
or we can do both.
what do you say about that ?
There was a problem hiding this comment.
we can ask the user to add the static path of the post in the config
I don't think specifying a static path per post is a good UX.
we can make the feed view publishable...configure the feed accordingly
Still a heavier lift than what I'd expect as a user. Essentially, I'd like to see it where you can provide a config value in your .env file - we'd also need to take into account other taxonomies (tags/topics) - and then a switch where you can either enable or disable the feature.
PR for issue #1334