Remove Cython and numpy build dependencies and implement work around suggested in #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…suggested in: https://github.com/cython/cython/blob/master/docs/src/reference/compilation.rst https://stackoverflow.com/questions/19919905/how-to-bootstrap-numpy-installation-in-setup-py numpy/numpy#2434 numpy/numpy#432 In order to allow ConfigSpace to be installed using requirements file.
Codecov Report
@@ Coverage Diff @@
## master #82 +/- ##
======================================
Coverage 46.2% 46.2%
======================================
Files 21 21
Lines 2610 2610
======================================
Hits 1206 1206
Misses 1404 1404Continue to review full report at Codecov.
|
|
Upon further research it seems to fail in awkward edge cases and I will find a workaround for my current issue until PEP518 is widely used. It seems that the current solution that most large frameworks implement is much more cumbersome than it's worth. |
This was referenced Jul 25, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/cython/cython/blob/master/docs/src/reference/compilation.rst
https://stackoverflow.com/questions/19919905/how-to-bootstrap-numpy-installation-in-setup-py
numpy/numpy#2434
numpy/numpy#432
In order to allow ConfigSpace to be installed using requirements file.
This change and the suggested change in autosklearn will allow the project to be independently installed.