Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor vm.Initialize into factory.New #2579

Open
joshua-kim opened this issue Jan 3, 2024 · 3 comments
Open

Refactor vm.Initialize into factory.New #2579

joshua-kim opened this issue Jan 3, 2024 · 3 comments
Assignees
Labels
cleanup Code quality improvement lifecycle/stale

Comments

@joshua-kim
Copy link
Contributor

joshua-kim commented Jan 3, 2024

Currently, VM instances invoke Initialize after being created by New. We can just move all initialization into Factory's New instead of having lazy-initialization pattern to simplify code.

@joshua-kim joshua-kim self-assigned this Jan 3, 2024
@joshua-kim joshua-kim changed the title Refactor vm.Initialize Refactor vm.Initialize into factory.New Jan 3, 2024
@joshua-kim joshua-kim added the cleanup Code quality improvement label Jan 16, 2024
@joshua-kim
Copy link
Contributor Author

First PR in this running story to remove CreateStaticHandlers, which is needed because we create a new instance of the VM and tear it down just to set up our static apis. #2589

@joshua-kim
Copy link
Contributor Author

joshua-kim commented Jan 17, 2024

Next PR is to refactor the feature extension code out of the VM Manager, so we can guarantee that we're returning a concrete VM type. #2578

Copy link

This issue has become stale because it has been open 60 days with no activity. Adding the lifecycle/frozen label will cause this issue to ignore lifecycle events.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code quality improvement lifecycle/stale
Projects
Status: In Progress 🏗
Development

No branches or pull requests

1 participant