Remove CreateStaticHandlers from VM interface #2589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshua-kim
force-pushed
the
remove-static-handlers
branch
from
43c4e80
to
b54585d
Compare
Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
joshua-kim
force-pushed
the
remove-static-handlers
branch
from
b54585d
to
c647075
Compare
joshua-kim
changed the title
joshua-kim
requested review from
abi87,
gyuho,
marun,
danlaine,
dhrubabasu and
StephenButtolph
as code owners
dhrubabasu
approved these changes
Jan 16, 2024
StephenButtolph
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Removes static apis. These are currently exposed to let users interact with a VM without it being initialized, but we can avoid this complexity by replacing a static api with some static function that isn't bound to the VM.
How this works
Removes the static handlers from the VM interface.
The static api code still exists to create genesis files/etc. Follow-up issue will be done to refactor this into static functions instead of having the useless static api struct.
How this was tested
CI