Unexport fields from gossip.BloomFilter #2547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenButtolph
added
vm
StephenButtolph
requested review from
danlaine and
joshua-kim
as code owners
1 task
StephenButtolph
commented
Dec 23, 2023
| @@ -152,6 +152,5 @@ func (g *gossipMempool) GetFilter() (bloom []byte, salt []byte, err error) { | |||
| g.lock.RLock() | |||
| defer g.lock.RUnlock() | |||
|
|
|||
| bloomBytes, err := g.bloom.Bloom.MarshalBinary() | |||
| return bloomBytes, g.bloom.Salt[:], err | |||
There was a problem hiding this comment.
This was a bug - the salt bytes returned here would be modified by calls to ResetBloomFilterIfNeeded and could result in racy behavior.
dhrubabasu
approved these changes
Dec 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
This has been introduced multiple times as a bug. Most of the times it was caught before merging... However, it made it through review in #2490. This PR moves the problematic implementation into the SDK and adds a regression test.
How this works
The
Saltfield is overwritten duringResetBloomFilterIfNeeded. So, the binary representation ofSaltmust be copied to be used safely.How this was tested