Acceptance Proofs #75
Conversation
Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
joshua-kim
force-pushed
the
consensus-proofs
branch
from
4ed9cde
to
c929052
Compare
|
Images seem to look strange in the diff but I believe they will work once merged (preview): https://github.com/joshua-kim/ACPs/blob/consensus-proofs/ACPs/75_consensus_proofs/75-consensus-proofs.md |
|
Repeating @richardpringle 's suggestion on ACP-73: #73 (comment), it would be great to add a link to the branch/relevant file to the PR description, so you can quickly jump to it. |
| PChainHeight uint64 | ||
| Timestamp time.Time | ||
| Proposer ids.NodeID | ||
| + Proof []byte |
There was a problem hiding this comment.
Do we want to do this in a separate struct or put this on some sort of delay (i.e. proof for 256 blocks ago)? Otherwise, we can't support multiple pending blocks AFAICT.
There was a problem hiding this comment.
This is pseudocode just intended to be used as a reference so if it's in a separate struct/not I don't have a strong opinion on. Regarding a delay - I believe this does need to be on a delay as I think it needs to be the proof for the block at PChainHeight which is currently already on a delay via window-ing.
|
@joshua-kim, you |
Co-authored-by: aaronbuchwald <aaron.buchwald56@gmail.com>
Co-authored-by: aaronbuchwald <aaron.buchwald56@gmail.com>
Co-authored-by: aaronbuchwald <aaron.buchwald56@gmail.com>
joshua-kim
requested review from
patrick-ogrady,
aaronbuchwald and
michaelkaplan13
Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
| ACP: 75 | ||
| Title: Acceptance Proofs | ||
| Author(s): Joshua Kim | ||
| Discussions-To: https://github.com/avalanche-foundation/ACPs/discussions/76 |
There was a problem hiding this comment.
I will update this to the official discussion after merging.
ACP to introduce consensus proofs into the ProposerVM block header
Rendered.