Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Execute SG changes e2e tests #189

Closed
wants to merge 5 commits into from
Closed

[WIP] Execute SG changes e2e tests #189

wants to merge 5 commits into from

Conversation

a-hilaly
Copy link
Member

@a-hilaly a-hilaly commented May 2, 2024

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 2, 2024
@ack-prow ACK Prow
Copy link

ack-prow bot commented May 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot requested review from jljaco and vijtrip2 May 2, 2024 15:59
@ack-prow ack-prow bot added the approved label May 2, 2024
@a-hilaly
Copy link
Member Author

/test all

@a-hilaly
Copy link
Member Author

a-hilaly commented Jun 3, 2024

/retest

@a-hilaly
Run
2391337
@a-hilaly
Update tests
50f1294
@a-hilaly
add
862d33c 
Signed-off-by: Amine Hilaly <hilalyamine@gmail.com>
@a-hilaly a-hilaly force-pushed the sgrefss branch 2 times, most recently from 42dd428 to 66be239 Compare June 3, 2024 08:19
@a-hilaly a-hilaly force-pushed the sgrefss branch 2 times, most recently from 9d820c3 to 4e9a61d Compare June 3, 2024 08:47
@ack-prow ACK Prow
Copy link

ack-prow bot commented Jun 3, 2024

@a-hilaly: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ec2-kind-e2e 4e9a61d link true /test ec2-kind-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@a-hilaly
Copy link
Member Author

a-hilaly commented Jun 3, 2024

Closing in favor of #194

@a-hilaly a-hilaly closed this Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jljaco jljaco Awaiting requested review from jljaco

@vijtrip2 vijtrip2 Awaiting requested review from vijtrip2

Assignees
No one assigned
Labels
approved do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Milestone
No milestone
1 participant
@a-hilaly