Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate DBSnpashot resource #181

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

a-hilaly
Copy link
Member

@a-hilaly a-hilaly commented Apr 9, 2024

Brings a new resource DBSnapshot to the rds-controller

  • Adds generator.yaml and necessary hooks
  • Adds e2e tests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Brings a new resource `DBSnapshot` to the rds-controller

- Adds generator.yaml and necessary hooks
- Adds e2e tests

Signed-off-by: Amine Hilaly <hilalyamine@gmail.com>
Copy link

ack-prow bot commented Apr 9, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ack-prow ack-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 9, 2024
@a-hilaly a-hilaly marked this pull request as ready for review April 9, 2024 15:02
@ack-prow ack-prow bot requested review from jljaco and vijtrip2 April 9, 2024 15:02
Copy link

ack-prow bot commented Apr 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot added approved and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Apr 9, 2024
@ack-prow ack-prow bot requested a review from jaypipes April 9, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant