Integrate restart policy into the container object #4160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singholt
reviewed
Apr 29, 2024
timj-hh
reviewed
Apr 30, 2024
sparrc
force-pushed
the
crp-models-2
branch
4 times, most recently
from
c3f6b64
to
5514c22
Compare
timj-hh
approved these changes
May 6, 2024
singholt
approved these changes
May 6, 2024
mye956
reviewed
May 6, 2024
| { | ||
| name: "enabled restart policy", | ||
| container: &Container{ | ||
| RestartPolicy: &restart.RestartPolicy{ |
There was a problem hiding this comment.
Just curious, do we/are there plans to validate RestartPolicy isn't empty if restart policy is enabled when we receive the task payload?
There was a problem hiding this comment.
That's a good question, we may want to validate that when we initialize the restart trackers, let me sync with Fargate dataplane on how we want to do that
There was a problem hiding this comment.
👍 thanks Cam! I also have no issues for this to be a follow up
mye956
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
go mod vendorin the agent/ dir to pull in ecs-agent/ shared lib changes.Exact struct naming is still subject to change but this should roughly match the GA feature.
Testing
New tests cover the changes:
Description for the changelog
NA
Does this PR include breaking model changes? If so, Have you added transformation functions?
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.