Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ev geo mean #2640

Draft
wants to merge 4 commits into
base: dev
Choose a base branch
from
Draft

Ev geo mean #2640

wants to merge 4 commits into from

Conversation

jaheba
Copy link
Contributor

@jaheba jaheba commented Feb 10, 2023

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Please tag this pr with at least one of these labels to make our release process faster: BREAKING, new feature, bug fix, other change, dev setup

@jaheba jaheba mentioned this pull request Feb 10, 2023
@melopeo
Copy link
Contributor

melopeo commented Feb 10, 2023

The geometric mean is only defined for non-negative values, i.e. x >= 0. Do we have a check on this condition?

@lostella
Copy link
Contributor

It may be ok to just let this fail at runtime in case (values<=0).any()

@lostella lostella added new feature (one of pr required labels) enhancement New feature or request and removed new feature (one of pr required labels) labels Feb 17, 2023
@jaheba
Copy link
Contributor Author

jaheba commented Feb 20, 2023

This shouldn't work yet.

@jaheba jaheba added the help wanted Extra attention is needed label Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants