RFC: zebras.TimeFrame. #2644
Draft
RFC: zebras.TimeFrame. #2644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huibinshen
reviewed
Feb 14, 2023
| Both classes have easy to use constructors in ``zebras.time_frame`` and | ||
| ``zebras.split_frame``. | ||
|
|
||
| ## Discussion |
There was a problem hiding this comment.
How about missing values?
There was a problem hiding this comment.
Missing values can be handled within TimeFrame by adding another column to it. I don't think we need to add a special case for this.
huibinshen
reviewed
Feb 14, 2023
| * We can implement custom behaviour such as ``.split`` easily on ``TimeFrame``. | ||
| * ``SplitFrame`` has a notion of past and future. | ||
|
|
||
| ## Obstacles |
There was a problem hiding this comment.
Agree, this seems a big change and gain should outweigh the effort.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered
Started implementation in #2609
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Please tag this pr with at least one of these labels to make our release process faster: BREAKING, new feature, bug fix, other change, dev setup