Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(options): add blur option plus documentation #24

Merged
merged 1 commit into from Feb 26, 2018
Merged

feat(options): add blur option plus documentation #24

merged 1 commit into from Feb 26, 2018

Conversation

axe312ger
Copy link
Owner

@axe312ger axe312ger commented Feb 23, 2018

Hey there,

thank you for this wonderful primitive Node integration. You saved me a lot of work. I am using it to bring SQIP to Gatsby, a React static site generator. gatsbyjs/gatsby#4205

This will add an option to configure the blur value of the svg to allow more artistic approaches, especially for big images.

I included LQIP versions of the demo images and added non-default blur examples with more shapes. The readme now contains a table with file sizes to compare, too. Quick preview: https://github.com/axe312ger/sqip/blob/feat/add-blur-to-options/README.md

Thank you again,
Benedikt

Copy link
Collaborator

@efegurkan efegurkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@efegurkan efegurkan merged commit f6ec0f3 into axe312ger:master Feb 26, 2018
@axe312ger axe312ger deleted the feat/add-blur-to-options branch February 26, 2018 10:04
@axe312ger
Copy link
Owner Author

axe312ger commented Feb 26, 2018

Awesome. Thank you so much :)

Next PR coming soon 🙈

@axe312ger axe312ger added this to the 1.0.0 milestone Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants