#380 Add net60 as additional target framework #381
Conversation
|
@thompson-tomo Thanks! Please have a look at the failing build on appveyor for this PR. |
|
@axunonb have gone and added an additional dependency to ZString to resolve the build issue. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## version/3.5.0 #381 +/- ##
============================================
Coverage 96% 96%
============================================
Files 92 92
Lines 3233 3233
============================================
Hits 3117 3117
Misses 116 116 ☔ View full report in Codecov by Sentry. |
|
Thanks for the fix. If we added net60, shouldn't this cover the main and all extension projects? |
|
Hmm, there is 2 trains of thought:
I don't have a strong opinion either way but do tend for send one due to package size reduction. |
axunonb
changed the title
|
Adding NET60 as a target framework to only 1-2 projects is not enough. We're ready to go this step, but for all SmartFormat projects. Cysharp/ZString released v2.6.0 lately, which also targets NET60 and NET70. All this requires a deeper look into all consequences and possible issues. Maybe we can finally reference Cysharp/ZString as a package directly. |
axunonb
changed the title
thompson-tomo
force-pushed
the
chore/#380_AddNet6
branch
from
ac74a47
to
891387b
Compare
|
Have gone and cleaned up properties which has allowed me to bump all packages in 1 hit. I have overridden the TFM for the base package due to nullability issues which someone should look at. |
|
We've created a new branch v3.5.0. |
thompson-tomo
force-pushed
the
chore/#380_AddNet6
branch
from
891387b
to
fe62d1f
Compare
|
@axunonb requested changes have been made and all builds now. |
| <UseWindowsForms>true</UseWindowsForms> | ||
| <ApplicationIcon>SmartFormat.Demo.ico</ApplicationIcon> | ||
| <LangVersion>8.0</LangVersion> | ||
| <Nullable>disable</Nullable> | ||
| <NoWarn>1591,1573</NoWarn> |
| @@ -9,6 +9,8 @@ | |||
| <SignAssembly>true</SignAssembly> | |||
| <AssemblyName>Performance_v27</AssemblyName> | |||
| <RootNamespace>Performance</RootNamespace> | |||
| <Nullable>disable</Nullable> | |||
| <NoWarn>1591,1573</NoWarn> | |||
| <LangVersion>9.0</LangVersion> | ||
| <AssemblyOriginatorKeyFile>../SmartFormat/SmartFormat.snk</AssemblyOriginatorKeyFile> | ||
| <SignAssembly>true</SignAssembly> | ||
| <Nullable>disable</Nullable> | ||
| <NoWarn>1591,1573</NoWarn> |
axunonb
changed the title
|
LGTM, thanks for the PR and your initiative. |
* Reference to Cysharp ZString v2.6.0 package (#382) * Reference Cysharp `ZString` v2.6.0 in `SmartFormat` project (net461 target use the netstandard2.0 assemblies) * Remove project `SmartFormat.Zstring` * Move internal static class ZStringBuilderExtensions to namespace SmartFormat.ZString * Rename ZStringBuilderExtensions to ZStringBuilderUtilities * Exclude ZString wrappers from code coverage (#384) * Flag `ZStringBuilder` and `ZStringWriter`with `[ExcludeFromCodeCoverage]` * Add AltCoverAttributeFilter="ExcludeFromCodeCoverage" in CI tests * #380 Add net60 as additional target framework (#381) * #380 Add net 6 to STJ project and make other dependencies conditional * Optimize package properties. * Fix nullability and warning issues for Demo and Performance projects * chore: net60/ZString related housekeeping (#385) * Directory.Build.props: Remove duplicate entries from Demo and Performance projects * Enable NRT for Demo and Performance projects * Remove folder SmartFormat.ZString from former projects SmartFormat.ZString * Remove obsolete entries from SmartFormat.sln * Remove reference to former SmartFormat.ZString.dll from SmartFormat.csproj * Enable net60 for project SmartFormat (#387) * feat: Add net8.0 as a target framework (#388) * Mark CTOR overload (System.Runtime.Serialization.SerializationInfo info, System.Runtime.Serialization.StreamingContext context) as obsolete (like it is in net8.0). * Update proprocessor directives and nuget packages * Change appveyor_build_worker_image to Ubuntu2204 * Add net8.0 as target framework * Update target framework net461 to net462 * Bump version to v3.4.0 --------- Co-authored-by: James Thompson <thompson.tomo@outlook.com>
Makes eliminated packages where they can be provided by the framework by using conditions and added net 6 to STJ so that it can also become optional.
Closes #380