Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference Cysharp ZString v2.6.0 package #382

Merged
merged 1 commit into from
May 10, 2024

Conversation

axunonb
Copy link
Member

@axunonb axunonb commented May 10, 2024

  • Reference Cysharp ZString v2.6.0 in SmartFormat project (net461 target uses the netstandard2.0 assemblies)
  • Remove project SmartFormat.Zstring
  • Move internal static class ZStringBuilderExtensions to namespace SmartFormat.ZString
  • Rename ZStringBuilderExtensions to ZStringBuilderUtilities

* Reference Cysharp `ZString` v2.6.0 in `SmartFormat` project (net461 target use the netstandard2.0 assemblies)
* Remove project `SmartFormat.Zstring`
* Move internal static class ZStringBuilderExtensions to namespace SmartFormat.ZString
* Rename ZStringBuilderExtensions to ZStringBuilderUtilities
Copy link

codecov bot commented May 10, 2024

Codecov Report

Attention: Patch coverage is 10.37736% with 95 lines in your changes are missing coverage. Please review.

Project coverage is 91%. Comparing base (c48f7c6) to head (0b1f676).

Files Patch % Lines
src/SmartFormat/ZString/ZStringBuilder.cs 3% 59 Missing ⚠️
src/SmartFormat/ZString/ZStringWriter.cs 0% 36 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           version/3.5.0   #382    +/-   ##
=============================================
- Coverage             96%    91%    -5%     
=============================================
  Files                 92     94     +2     
  Lines               3233   3434   +201     
=============================================
+ Hits                3117   3133    +16     
- Misses               116    301   +185     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@axunonb axunonb merged commit 693243b into axuno:version/3.5.0 May 10, 2024
2 of 4 checks passed
@axunonb axunonb deleted the pr/ref-cysharp-zstring branch May 10, 2024 12:45
axunonb added a commit that referenced this pull request May 15, 2024
* Reference to Cysharp ZString v2.6.0 package (#382)
* Reference Cysharp `ZString` v2.6.0 in `SmartFormat` project (net461 target use the netstandard2.0 assemblies)
* Remove project `SmartFormat.Zstring`
* Move internal static class ZStringBuilderExtensions to namespace SmartFormat.ZString
* Rename ZStringBuilderExtensions to ZStringBuilderUtilities
* Exclude ZString wrappers from code coverage (#384)
* Flag `ZStringBuilder` and `ZStringWriter`with `[ExcludeFromCodeCoverage]`
* Add AltCoverAttributeFilter="ExcludeFromCodeCoverage" in CI tests
* #380 Add net60 as additional target framework (#381)
* #380 Add net 6 to STJ project and make other dependencies conditional
* Optimize package properties.
* Fix nullability and warning issues for Demo and Performance projects
* chore: net60/ZString related housekeeping (#385)
* Directory.Build.props: Remove duplicate entries from Demo and Performance projects
* Enable NRT for Demo and Performance projects
* Remove folder SmartFormat.ZString from former projects SmartFormat.ZString
* Remove obsolete entries from SmartFormat.sln
* Remove reference to former SmartFormat.ZString.dll from SmartFormat.csproj
* Enable net60 for project SmartFormat (#387)
* feat: Add net8.0 as a target framework (#388)
* Mark CTOR overload (System.Runtime.Serialization.SerializationInfo info, System.Runtime.Serialization.StreamingContext context) as obsolete (like it is in net8.0).
* Update proprocessor directives and nuget packages
* Change appveyor_build_worker_image to Ubuntu2204
* Add net8.0 as target framework
* Update target framework net461 to net462
* Bump version to v3.4.0

---------

Co-authored-by: James Thompson <thompson.tomo@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant