Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

using template literals in ch02 #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

using template literals in ch02 #1

wants to merge 1 commit into from

Conversation

gagoar
Copy link
Contributor

@gagoar gagoar commented Nov 16, 2016 •
edited

Hello!

I though giving the es6 and es5 version of ch02 example, templates literals should be included in the es6 version.

Cheers,

Lroca88
Lroca88 reviewed Aug 11, 2018
View reviewed changes
Copy link
Contributor

@Lroca88 Lroca88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Template literals are much cleaner in my opinion. Nice catch @gagoar.
Any thoughts @azat-co?

jrleader pushed a commit to jrleader/react-quickly that referenced this pull request Nov 23, 2020
Homework azat-co#1: Convert Timer to a stateless component
db8f8e8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lroca88 Lroca88 Lroca88 left review comments

@naderalfakesh naderalfakesh naderalfakesh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gagoar @Lroca88 @naderalfakesh