New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: introduce rust extension #368
base: 2.1.x
Are you sure you want to change the base?
Conversation
Pull Request Test Coverage Report for Build 3556460766
馃挍 - Coveralls |
Signed-off-by: azjezz <azjezz@protonmail.com>
os: | ||
- "ubuntu-latest" | ||
- "macos-latest" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that the extension is not loaded when running benchmarks on macOS, not sure why yet ( @veewee maybe you can have a look at that? )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On mac, a compilation results in libpsl.dylib
instead of libpsl.so
.
The formats are interchangeable - so you should be able to add this step to make compile:
mv libpsl.dylib libpsl.so || true
Locally, This results in:
However, if I do not run this additional step. I get this error on second benchmark run:
azjezz/psl/vendor/phpbench/phpbench/lib/Environment/Provider/template/php.template" did not return an array, got:
Warning: PHP Startup: Unable to load dynamic library 'extension/target/release/libpsl.so'
Not sure if I need to do additional things to compile. Tried setting the same env vars as the setup script:
LIBCLANG_PATH=/usr/local/opt/llvm@13/bin
SDKROOT=$(xcrun --show-sdk-path)
Note: needed to disable opcache here:
azjezz/psl/vendor/phpbench/phpbench/lib/Environment/Provider/template/php.template" did not return an array, got:
Warning: JIT is incompatible with third party extensions that override zend_execute_ex(). JIT disabled. in Unknown on line 0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JIT is incompatible with third party extensions that override zend_execute_ex()
the extension is compatibly with JIT, it's already used in CI with linux, and i use it locally, are you sure pcov and xdebug are disabled? ( both are not compatible with JIT iirc )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, pcov was enabled..
Signed-off-by: azjezz <azjezz@protonmail.com>
path: | | ||
~/.composer/cache | ||
vendor | ||
~/.cargo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is https://github.com/Swatinem/rust-cache for this
No description provided.