Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use throwable exceptions #14

Merged
merged 20 commits into from Apr 15, 2019
Merged

Use throwable exceptions #14

merged 20 commits into from Apr 15, 2019

Conversation

balajirama
Copy link
Owner

@balajirama balajirama commented Apr 14, 2019 •
edited

The idea of this one is to make use of the Throwable Role and not use the Exception::Class.

  • Need to remove the Exception::Class

  • Add a small package of exceptions

  • Maintain POD for the exceptions thrown.

  • Update Changes

@balajirama balajirama self-assigned this Apr 14, 2019
@codecov
Copy link

codecov bot commented Apr 14, 2019 •
edited

Codecov Report

Merging #14 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #14   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           3      4    +1     
  Lines         154    161    +7     
  Branches       38     39    +1     
=====================================
+ Hits          154    161    +7
Impacted Files Coverage Δ
lib/Text/Parser/Multiline.pm 100% <ø> (ø) ⬆️
lib/Text/Parser.pm 100% <100%> (ø) ⬆️
lib/Text/Parser/Errors.pm 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3dfe89c...7aab741. Read the comment docs.

@balajirama
Copy link
Owner Author

Closes #13

@balajirama
Changing Multiline exceptions into Throwables
f2ba355 
1. New error classes added.
2. Updated code in Multiline.pm
3. Refactored and made code nice looking
4. Fixed all tests to pass.
@balajirama
Copy link
Owner Author

balajirama commented Apr 14, 2019 •
edited

@balajirama balajirama added bug Something isn't working documentation This is an improvement to the documentation enhancement New feature or request labels Apr 15, 2019
@balajirama balajirama merged commit 4bfbcbf into master Apr 15, 2019
@balajirama balajirama deleted the use-throwable-exceptions branch April 15, 2019 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@balajirama balajirama

Labels
bug Something isn't working documentation This is an improvement to the documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@balajirama