General cleanup. Moved the hide views event to the form where it real…

…ly belongs
baphled · Jun 25, 2010 · 232440f · 232440f
1 parent 63d6232
commit 232440f
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 13 deletions.
diff --git a/public/javascripts/application.js b/public/javascripts/application.js
@@ -24,11 +24,6 @@ $(document).ready(function() {
     (event.type == 'mouseover')? $(this).addClass('ui-state-hover') : $(this).removeClass('ui-state-hover');
   });
 
-  /**
-   * We don't want our checkboxes viewable initially
-   */
-  $('.views').hide();
-
   /**
    * Handling the viewing and hiding of our item checkboxes
    */

diff --git a/public/javascripts/hover_dialog.js b/public/javascripts/hover_dialog.js
@@ -2,21 +2,20 @@
 $(document).ready(function() {
 
   // Create acessors for our hover dialog
-  var $formAction = $('form').attr('action'),
-      formIdArray = $('form').attr('id').split('_');
+  var formIdArray = $('form').attr('id').split('_');
       resourceSingular = formIdArray[1],
       resourcePlural = resourceSingular.pluralize(),
       $tagInput = $('input#'+ resourceSingular + '_tag_list'),
       $tagInputWrapper = $('li#'+ resourceSingular + '_tag_list_input'),
       $hoverDialog = $("<div></div>")
-      .addClass('hover ui-widget ui-widget-content ui-corner-all')
-      .insertAfter($tagInput)
-      .hide();
+        .addClass('hover ui-widget ui-widget-content ui-corner-all')
+        .insertAfter($tagInput)
+        .hide();
 
   $tagInput.keyup(function() {
-    $url = '/' + resourcePlural + "/tags.json";
+    var url = '/' + resourcePlural + "/tags.json";
     $.ajax({
-      url: $url,
+      url: url,
       data: $tagInput.serialize(),
       dataType: 'json',
       type: 'GET',
@@ -51,7 +50,7 @@ $(document).ready(function() {
 
 		      // if there are no more tags we should hide the dialog panel
 		      // @todo cleanup as this could be done cleaner
-		      if ($hoverDialog.html() == ('  ' || ' ') ) {
+		      if ($hoverDialog.html().trim() == '') {
 		        $hoverDialog.fadeOut();
 		      }
           return false;