thread_list: use unique_ptr for pimpl of class ThreadList

bareos · Sep 2, 2019 · 16bea07 · 16bea07
1 parent 870ed9d
commit 16bea07
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/core/src/lib/thread_list.cc b/core/src/lib/thread_list.cc
@@ -22,11 +22,15 @@
 #include "include/bareos.h"
 #include "thread_list.h"
 #include "include/jcr.h"
+#include "include/make_unique.h"
 #include "lib/berrno.h"
 #include "lib/bsock.h"
 
 #include <algorithm>
+#include <condition_variable>
 #include <thread>
+#include <mutex>
+#include <set>
 
 struct ThreadListItem {
   std::thread WorkerThread_;
@@ -53,8 +57,8 @@ struct ThreadListPrivate {
   bool WaitForThreadsToShutdown();
 };
 
-ThreadList::ThreadList() { impl_ = new ThreadListPrivate; }
-ThreadList::~ThreadList() { delete impl_; }
+ThreadList::ThreadList() : impl_(std::make_unique<ThreadListPrivate>()) {}
+ThreadList::~ThreadList() = default;
 
 void ThreadList::Init(int maximum_thread_count,
                       std::function<void*(ConfigurationParser* config,

diff --git a/core/src/lib/thread_list.h b/core/src/lib/thread_list.h
@@ -52,7 +52,7 @@ class ThreadList {
   ThreadList& operator=(const ThreadList&& rhs) = delete;
 
  private:
-  ThreadListPrivate* impl_ = nullptr;
+  std::unique_ptr<ThreadListPrivate> impl_;
 };