webui: Fixed always active debug messages in error.log

Fixes #1059: Webui spams Apache error_log with bconsole messages
bareos · Jul 8, 2019 · 8fd7e89 · 8fd7e89
1 parent e940e01
commit 8fd7e89
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 6 deletions.
diff --git a/webui/module/Auth/src/Auth/Controller/AuthController.php b/webui/module/Auth/src/Auth/Controller/AuthController.php
@@ -88,7 +88,7 @@ public function loginAction()
             $this->bsock = $this->getServiceLocator()->get('director');
             $this->bsock->set_config($config['directors'][$director]);
             $this->bsock->set_user_credentials($username, $password);
-            error_log($username);
+            //error_log($username);
 
             if($this->bsock->connect_and_authenticate()) {
                $_SESSION['bareos']['director'] = $director;

diff --git a/webui/vendor/Bareos/library/Bareos/BSock/BareosBSock.php b/webui/vendor/Bareos/library/Bareos/BSock/BareosBSock.php
@@ -460,7 +460,9 @@ private function connect()
          return false;
       }
 
-      error_log("console_name: ".$this->config['console_name']);
+      if($this->config['debug']) {
+         error_log("console_name: ".$this->config['console_name']);
+      }
 
       $port = $this->config['port'];
       $remote = "tcp://" . $this->config['host'] . ":" . $port;
@@ -581,13 +583,17 @@ private function connect()
             return false;
           }
           $recv = self::receive();
-          error_log($recv);
+          if($this->config['debug']) {
+             error_log($recv);
+          }
       }
 
       if (!strncasecmp($recv, "1000", 4)) {
-        $recv = self::receive();
-        error_log($recv);
-        return true;
+         $recv = self::receive();
+         if($this->config['debug']) {
+            error_log($recv);
+         }
+         return true;
       }
 
       return false;