Fix some clang compiler warnings

src/console/console.cc

@@ -1114,7 +1114,7 @@ static int dir_psk_client_callback(char *identity,
    } else {
       static char *psk_identity = (char *)"Nasenbaer";
 
-      unsigned int ret = snprintf(identity, max_identity_len, "%s", psk_identity);
+      int ret = bsnprintf(identity, max_identity_len, "%s", psk_identity);
       if (ret < 0 || (unsigned int)ret > max_identity_len) {
          Dmsg0(100, "Error, psk_identify too long\n");
          result = 0;

src/dird/ndmp_dma_backup_NDMP_NATIVE.cc

@@ -117,11 +117,6 @@ int ndmp_load_next(struct ndm_session *sess) {
          goto bail_out;
       }
 
-      if ( media->slot_addr < 0 ) {
-         Jmsg(jcr, M_FATAL, 0, _("lookup_storage_mapping failed\n"));
-         goto bail_out;
-      }
-
       slot_number_t slotnumber = lookup_storage_mapping(store, slot_type_normal, LOGICAL_TO_PHYSICAL, mr.Slot);
       /*
        * check if lookup_storage_mapping was successful

src/filed/fd_plugins.cc

@@ -1763,7 +1763,7 @@ static inline bpContext *instantiate_plugin(JCR *jcr, Plugin *plugin, char insta
    b_plugin_ctx *b_ctx;
 
    b_ctx = (b_plugin_ctx *)malloc(sizeof(b_plugin_ctx));
-   (b_plugin_ctx *)memset(b_ctx, 0, sizeof(b_plugin_ctx));
+   b_ctx = (b_plugin_ctx *)memset(b_ctx, 0, sizeof(b_plugin_ctx));
    b_ctx->jcr = jcr;
    b_ctx->plugin = plugin;
 

src/lib/tls_openssl.cc

@@ -523,7 +523,7 @@ static unsigned int psk_client_cb(SSL *ssl,
           * Now let's check if the given identity is the same and
           * provide the psk.
           */
-         unsigned int ret =
+         int ret =
              bsnprintf(identity, max_identity_len, "%s", credentials->get_identity().c_str());
 
          if (ret < 0 || (unsigned int)ret > max_identity_len) {
@@ -828,19 +828,19 @@ std::shared_ptr<TLS_CONTEXT> tls_cert_t::CreateServerContext(
 }
 
 bool tls_cert_t::enabled(u_int32_t policy) {
-   return (policy >> tls_cert_t::policy_offset) & BNET_TLS_ENABLED == BNET_TLS_ENABLED;
+   return ((policy >> tls_cert_t::policy_offset) & BNET_TLS_ENABLED) == BNET_TLS_ENABLED;
 }
 
 bool tls_cert_t::required(u_int32_t policy) {
-   return (policy >> tls_cert_t::policy_offset) & BNET_TLS_REQUIRED == BNET_TLS_REQUIRED;
+   return ((policy >> tls_cert_t::policy_offset) & BNET_TLS_REQUIRED) == BNET_TLS_REQUIRED;
 }
 
 bool tls_psk_t::enabled(u_int32_t policy) {
-   return (policy >> tls_psk_t::policy_offset) & BNET_TLS_ENABLED == BNET_TLS_ENABLED;
+   return ((policy >> tls_psk_t::policy_offset) & BNET_TLS_ENABLED) == BNET_TLS_ENABLED;
 }
 
 bool tls_psk_t::required(u_int32_t policy) {
-   return (policy >> tls_psk_t::policy_offset) & BNET_TLS_REQUIRED == BNET_TLS_REQUIRED;
+   return ((policy >> tls_psk_t::policy_offset) & BNET_TLS_REQUIRED) == BNET_TLS_REQUIRED;
 }
 
 std::shared_ptr<TLS_CONTEXT> tls_psk_t::CreateClientContext(

src/plugins/filed/example-plugin-fd.cc

@@ -199,10 +199,10 @@ static bRC handlePluginEvent(bpContext *ctx, bEvent *event, void *value)
       printf("plugin: BackupEnd\n");
       break;
    case bEventLevel:
-      printf("plugin: JobLevel=%c %d\n", (int64_t)value, (int64_t)value);
+      printf("plugin: JobLevel=%c %ld\n", (int64_t)value, (int64_t)value);
       break;
    case bEventSince:
-      printf("plugin: since=%d\n", (int64_t)value);
+      printf("plugin: since=%ld\n", (int64_t)value);
       break;
    case bEventStartRestoreJob:
       printf("plugin: StartRestoreJob\n");

src/plugins/filed/fd_common.h

@@ -66,28 +66,28 @@ DLL_IMP_EXP void reallyfree(const char *file, int line, void *fp);
 DLL_IMP_EXP void *sm_malloc(const char *fname, int lineno, unsigned int nbytes);
 DLL_IMP_EXP void sm_free(const char *file, int line, void *fp);
 
-inline void *operator new(size_t size, char const * file, int line)
+void *operator new(size_t size, char const * file, int line)
 {
    void *pnew = sm_malloc(file,line, size);
    memset((char *)pnew, 0, size);
    return pnew;
 }
 
-inline void *operator new[](size_t size, char const * file, int line)
+void *operator new[](size_t size, char const * file, int line)
 {
    void *pnew = sm_malloc(file, line, size);
    memset((char *)pnew, 0, size);
    return pnew;
 }
 
-inline void *operator new(size_t size)
+void *operator new(size_t size)
 {
    void *pnew = sm_malloc(__FILE__, __LINE__, size);
    memset((char *)pnew, 0, size);
    return pnew;
 }
 
-inline void *operator new[](size_t size)
+void *operator new[](size_t size)
 {
    void *pnew = sm_malloc(__FILE__, __LINE__, size);
    memset((char *)pnew, 0, size);
@@ -96,12 +96,12 @@ inline void *operator new[](size_t size)
 
 #define new   new(__FILE__, __LINE__)
 
-inline void operator delete(void *buf)
+void operator delete(void *buf) noexcept
 {
    sm_free( __FILE__, __LINE__, buf);
 }
 
-inline void operator delete[] (void *buf)
+void operator delete[] (void *buf) noexcept
 {
   sm_free(__FILE__, __LINE__, buf);
 }