Skip to content

Commit

Permalink
win32: Fix open_bpipe() in windows compat emulation.
Browse files Browse the repository at this point in the history
Fixes #632: fd-bpipe plugin merges stderr with stdout, which can result
            in corrupted backups.
  • Loading branch information
Marco van Wieringen committed Mar 11, 2016
1 parent bd780a7 commit ddb66e4
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/win32/compat/compat.c
Expand Up @@ -3436,7 +3436,7 @@ static void CloseHandleIfValid(HANDLE handle)
}
}

BPIPE *open_bpipe(char *prog, int wait, const char *mode)
BPIPE *open_bpipe(char *prog, int wait, const char *mode, bool dup_stderr)
{
int mode_read, mode_write;
SECURITY_ATTRIBUTES saAttr;
Expand Down Expand Up @@ -3472,7 +3472,7 @@ BPIPE *open_bpipe(char *prog, int wait, const char *mode)
/*
* Create a pipe for the child process's STDOUT.
*/
if (! CreatePipe(&hChildStdoutRd, &hChildStdoutWr, &saAttr, 0)) {
if (!CreatePipe(&hChildStdoutRd, &hChildStdoutWr, &saAttr, 0)) {
ErrorExit("Stdout pipe creation failed\n");
goto cleanup;
}
Expand Down

0 comments on commit ddb66e4

Please sign in to comment.