Apply suggestions from code review

Co-authored-by: Andreas Rogge <andreas.rogge@bareos.com>
bareos · Oct 8, 2020 · ff2c5d2 · ff2c5d2
1 parent 4a687c3
commit ff2c5d2
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/core/src/plugins/filed/python/libcloud/BareosFdPluginLibcloud.py b/core/src/plugins/filed/python/libcloud/BareosFdPluginLibcloud.py
@@ -298,8 +298,6 @@ def start_backup_file(self, savepkt):
                 if self.options["fail_on_download_error"]:
                     self.active = False
                     error = True
-                else:
-                    pass
             elif worker_result == ABORT:
                 self.active = False
                 error = True

diff --git a/docs/manuals/source/TasksAndConcepts/Plugins.rst b/docs/manuals/source/TasksAndConcepts/Plugins.rst
@@ -1637,10 +1637,8 @@ Optional Plugin Options:
 This option in the config file is optional:
 
 fail_on_download_error
-   This parameter is by default False to keep a job running if for some reason a file cannot
-   be downloaded from a bucket because it is either deleted or moved to another space during
-   download. In this case a Job will be marked with warnings as this is the default of Bareos.
-   It is recommended not to change this option.
+   When this option is enabled, any error during a file download will fail the backup job.
+   By default a warning will be issued and the next file will be backed up.
 
 
 .. _PerconaXtrabackupPlugin: