Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Bsnprintf() implementation and add format attributes #1697

Draft
wants to merge 30 commits into
base: master
Choose a base branch
from

Conversation

arogge
Copy link
Member

@arogge arogge commented Feb 5, 2024

This PR replaces the implementation of Bvsnprintf() by the plain library functions.
We also add the attributes to all printf()-like functions to be able to detect problems at compile-time instead of crashing at runtime. As this produced a lot of problems, -Werror was disabled for format-related things (but should be re-enabled before this PR is merged).

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Check backport line
  • Required backport PRs have been created
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
  • the temporary commit disabling format errors has been removed
Tests
  • Decision taken that a test is required (if not, then remove this paragraph)
  • The choice of the type of test (unit test or systemtest) is reasonable
  • Testname matches exactly what is being tested
  • On a fail, output of the test leads quickly to the origin of the fault

@bruno-at-bareos bruno-at-bareos marked this pull request as draft February 6, 2024 10:58
@sebsura sebsura added the nobuild label Feb 9, 2024
@sebsura
Copy link
Contributor

sebsura commented Feb 9, 2024

I set this to no build to reduce the strain on jenkins. As soon as we get it to build locally this should be changed back.

@sebsura sebsura force-pushed the dev/arogge/master/replace-bsnprintf branch 2 times, most recently from dba59d4 to 5fb5295 Compare February 9, 2024 12:55
@sebsura sebsura removed the nobuild label Feb 20, 2024
@sebsura sebsura force-pushed the dev/arogge/master/replace-bsnprintf branch 5 times, most recently from faf3036 to 45ba003 Compare February 21, 2024 13:56
@sebsura sebsura force-pushed the dev/arogge/master/replace-bsnprintf branch 2 times, most recently from db2d385 to 6774b89 Compare February 22, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants