droplet compatible storage backend #1790
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arogge
force-pushed
the
scripted-storage-backend
branch
2 times, most recently
from
a2d86d8
to
4656423
Compare
Add a new test that restores the backup written by the droplet backend using another storage device. This checks that you can read droplet backups with another device.
previously OpenBpipe() would only take a non-const char* as the program parameter.
add Microsoft GSL (Guidelines Support Library) as a third-party library using CMake Package Manager.
Add a new backend "dplcompat" that is compatible to the droplet backend. This early prototype supports only restore operation.
This adds a new virtual function setup() to device that will be called when the device is created. Here the backend developer can run any device-specific initialization, like parsing options, checking device availability, etc. Returning false from that function will fail the device initialization.
These are mostly used for parsing device options
when a droplet device was released without ever being used, it could potentially crash.
While the droplet code we want to replace had integrated retries, the chunked_device is already able to do retries on its own.
This version is now able to support all Bareos backend operations.
with this change the program that will be used to access the storage can declare what options it supports (via the "options" subcommand). If one of those options is in Device Options, it will be added to the program's environment. If there are options in Device Options that neither dplcompat nor the program accept, this is treated as a configuration error.
s3cmd will report "DIROBJ" as size for the directory object. As this is not meaningful, we skip every record with a size that is not a number.
arogge
force-pushed
the
scripted-storage-backend
branch
from
bf7d1c3
to
9529753
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new storage backend "dplcompat" that can work as a drop-in replacement for the "droplet" backend.
This will replace the current S3 backend that uses the outdated Droplet library.
TODO:
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality
Tests