bareos-fd-vmware: Fix Restore as a new VM #1796
Open
+15
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have modify the vmware bareos plugin source code, so when restoring as a new VM, the VMware plugin will ignore if the backed up disk is not the same as the new VM.
The check_vm_disks_match() function will check whether the recovery job is restored as a new vm or not. If restored as a new VM, check_vm_disks_match() will return true even if the backed up disk is not the same as the new VM.
This PR should fix bug when VMware Plugin Restore as a new VM that i have mention on this report https://groups.google.com/g/bareos-users/c/RgHCwTfmQ5o/m/d-Q_DpdhAQAJ?utm_medium=email&utm_source=footer
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-tool
to have some simple automated checks run and a proper changelog record added.General
Source code quality
Tests