tools: remove perl in mtx changer #1816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add max_wait_drive variable with a default of 300s which can be extended in the mtx-changer.conf file to larger value (maybe needed for LTO9 drive due to calibration) - use awk expression if most cases - unify the way we use awk (-F, double quotes, etc) - shfmt -i2 -ci - shellcheck code - systemtests: add mtx-changer test - trim trailing whitespace on list cmd - improve readability of longer awk code use direct input in awk expression without variables Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com> (cherry picked from commit 68710b7)
Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com> (cherry picked from commit 64f747e)
arogge
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #1740 to bareos-23
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.Source code quality (if there were changes to the original PR)
Backport quality