rewrite zephyr scribelike markup parsing #172
Conversation
Shouldd produce a zephyr/zcribe string that won't interfere with other any zephyr/scribe directives you put around it. Fixes Barnowl::Style::boldify.
and surface it in perl as BarnOwl::ztext_stylestrip_full
| @@ -31,6 +31,7 @@ The following people have provided patches or other contributions: | |||
| DD Liu | |||
| Betsy Riley | |||
| Robert Jacobs | |||
| Google Inc. | |||
There was a problem hiding this comment.
Is Google Inc. actually a person who contributed?
There was a problem hiding this comment.
They claim copyright on the code in the patch, and the AUTHORS file is, among other things, the list of copyright holders.
There was a problem hiding this comment.
Perhaps s/people/entities/ on line 4?
"Corporations are people you know" :-}
|
This code is on the critical path for |
|
I have not, because it hadn't occurred to me, at least partially because I can reason about my code's time complexity (it was written to be O(n) time on the size of the input) and I can't duplicate the reasoning about the original code. (Also strpbrk is doing the same sort of table lookup (albeit in assembly language) and bulding the (admittedly simpler) table on every call.) |
While investigating something that turned out to be trac ticket #188, I looked at owl_fmtext_append_ztext and found that I couldn't unsee it, so here's a parser with a state machine that produces a syntax tree, that then gets rendered into fmtext. This turned out not to fix the bug; herein also find a ztext_protect function that can be used to fix the bug. Also a zwgc-style code strip (that doesn't just strip environments that barnowl understands) and support for @ roman (remove bold and underline).