Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emodb Admin Apikey, Replication Apikey - Exception #811

Open
wants to merge 62 commits into
base: main
Choose a base branch
from

Conversation

mukeshsbbv
Copy link
Contributor

Github Issue

1234

What Are We Doing Here?

Here is where you should describe the problem you are solving as it relates to the Github Issue referred above, adding any fine
details on the solution that might otherwise not be recognizable for someone
unfamiliar with the changes. Add some pictures if it helps.

How to Test and Verify

  1. Check out this PR
  2. Run Command X, Click Button Y
  3. Profit

Risk

Level

Low, Medium, or High. Give an indication of what you think is the level of change introduced by this PR. High means a massive change to a core functionality.
Low means a really minor change that shouldn't have any regression effect.

Required Testing

Smoke, Regression, or Manual. (All changes except documentation need smoke
testing at a minimum).

Risk Summary

Add one or a few complete sentences about the possible risks or concerns for
this change.

Code Review Checklist

  • Tests are included. If not, make sure you leave us a line or two for the reason.

  • Pulled down the PR and performed verification of at least being able to
    build and run.

  • Well documented, including updates to any necessary markdown files. When
    we inevitably come back to this code it will only take hours to figure out, not
    days.

  • Consistent/Clear/Thoughtful? We are better with this code. We also aren't
    a victim of rampaging consistency, and should be using this course of action.
    We don't have coding standards out yet for this project, so please make sure to address any feedback regarding STYLE so the codebase remains consistent.

  • PR has a valid summary, and a good description.

updated the version from 6.5.51-SNAPSHOT to 6.5.64-SNAPSHOT
updated the version from 6.5.51-SNAPSHOT to 6.5.64-SNAPSHOT
updated the version from 6.5.51-SNAPSHOT to 6.5.64-SNAPSHOT
updated the version from 6.5.51-SNAPSHOT to 6.5.64-SNAPSHOT
updated the version from 6.5.51-SNAPSHOT to 6.5.64-SNAPSHOT
updated the version from 6.5.51-SNAPSHOT to 6.5.64-SNAPSHOT
updated the version from 6.5.51-SNAPSHOT to 6.5.64-SNAPSHOT
updated the version from 6.5.51-SNAPSHOT to 6.5.64-SNAPSHOT
updated the version from 6.5.51-SNAPSHOT to 6.5.64-SNAPSHOT
updated the version from 6.5.51-SNAPSHOT to 6.5.64-SNAPSHOT
updated the version from 6.5.51-SNAPSHOT to 6.5.64-SNAPSHOT
updated the version from 6.5.51-SNAPSHOT to 6.5.64-SNAPSHOT
updated the version from 6.5.51-SNAPSHOT to 6.5.64-SNAPSHOT
updated the version from 6.5.51-SNAPSHOT to 6.5.64-SNAPSHOT
updated the version from 6.5.51-SNAPSHOT to 6.5.64-SNAPSHOT
updated the version from 6.5.51-SNAPSHOT to 6.5.64-SNAPSHOT
updated the version from 6.5.51-SNAPSHOT to 6.5.64-SNAPSHOT
updated the version from 6.5.51-SNAPSHOT to 6.5.64-SNAPSHOT
updated the version from 6.5.51-SNAPSHOT to 6.5.64-SNAPSHOT
updated the version from 6.5.51-SNAPSHOT to 6.5.64-SNAPSHOT
updated the version from 6.5.51-SNAPSHOT to 6.5.64-SNAPSHOT
updated the version from 6.5.51-SNAPSHOT to 6.5.64-SNAPSHOT
updated the version from 6.5.51-SNAPSHOT to 6.5.64-SNAPSHOT
updated the version from 6.5.51-SNAPSHOT to 6.5.64-SNAPSHOT
updated the version from 6.5.51-SNAPSHOT to 6.5.64-SNAPSHOT
updated the version from 6.5.51-SNAPSHOT to 6.5.64-SNAPSHOT
updated the version from 6.5.51-SNAPSHOT to 6.5.64-SNAPSHOT
updated the version from 6.5.51-SNAPSHOT to 6.5.64-SNAPSHOT
updated the version from 6.5.51-SNAPSHOT to 6.5.64-SNAPSHOT
updated the version from 6.5.51-SNAPSHOT to 6.5.64-SNAPSHOT
ReddyAnand-BV and others added 25 commits February 8, 2024 13:31
updated the version from 6.5.51-SNAPSHOT to 6.5.64-SNAPSHOT
updated the version from 6.5.51-SNAPSHOT to 6.5.64-SNAPSHOT
updated the version from 6.5.51-SNAPSHOT to 6.5.64-SNAPSHOT
updated the version from 6.5.51-SNAPSHOT to 6.5.64-SNAPSHOT
updated the version from 6.5.51-SNAPSHOT to 6.5.64-SNAPSHOT
updated the version from 6.5.51-SNAPSHOT to 6.5.64-SNAPSHOT
updated the version from 6.5.51-SNAPSHOT to 6.5.64-SNAPSHOT
updated the version from 6.5.51-SNAPSHOT to 6.5.64-SNAPSHOT
updated the version from 6.5.51-SNAPSHOT to 6.5.64-SNAPSHOT
updated the version from 6.5.51-SNAPSHOT to 6.5.64-SNAPSHOT
updated the version from 6.5.51-SNAPSHOT to 6.5.64-SNAPSHOT
updated the version from 6.5.51-SNAPSHOT to 6.5.64-SNAPSHOT
updated the version from 6.5.51-SNAPSHOT to 6.5.64-SNAPSHOT
updated the version from 6.5.51-SNAPSHOT to 6.5.64-SNAPSHOT
updated the version from 6.5.51-SNAPSHOT to 6.5.64-SNAPSHOT
updated the version from 6.5.51-SNAPSHOT to 6.5.64-SNAPSHOT
updated the version from 6.5.51-SNAPSHOT to 6.5.64-SNAPSHOT
updated the version from 6.5.51-SNAPSHOT to 6.5.64-SNAPSHOT
updated the version from 6.5.51-SNAPSHOT to 6.5.64-SNAPSHOT
updated the version from 6.5.51-SNAPSHOT to 6.5.64-SNAPSHOT
updated the version from 6.5.51-SNAPSHOT to 6.5.64-SNAPSHOT
@mukeshsbbv mukeshsbbv requested a review from a team as a code owner February 9, 2024 04:43
Copy link

gitguardian bot commented Feb 9, 2024

⚠️ GitGuardian has uncovered 38 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
6008657 Triggered Generic High Entropy Secret 1200b76 web-local/config-scantest.yaml View secret
6008657 Triggered Generic High Entropy Secret 1200b76 web-local/config-local.yaml View secret
6008657 Triggered Generic High Entropy Secret 1200b76 web-local/config-local-blob-role.yaml View secret
6008657 Triggered Generic High Entropy Secret 1200b76 web-local/config-web.yaml View secret
6008657 Triggered Generic High Entropy Secret 1200b76 docker/configs/config-web-dc2.yaml View secret
6008657 Triggered Generic High Entropy Secret 1200b76 docker/configs/config-stash-dc1.yaml View secret
6008657 Triggered Generic High Entropy Secret 1200b76 docker/configs/config-stash-dc2.yaml View secret
6008657 Triggered Generic High Entropy Secret 1200b76 web-local/config-local-2.yaml View secret
6008657 Triggered Generic High Entropy Secret 1200b76 quality/integration/src/test/resources/config-stash-role.yaml View secret
6008657 Triggered Generic High Entropy Secret 1200b76 docker/configs/config-megabus-dc1.yaml View secret
6008657 Triggered Generic High Entropy Secret 1200b76 web-local/config-jenkins.yaml View secret
6008657 Triggered Generic High Entropy Secret 1200b76 docker/configs/config-megabus-dc2.yaml View secret
6008657 Triggered Generic High Entropy Secret 1200b76 sdk/src/main/resources/emodb-default-config.yaml View secret
6008657 Triggered Generic High Entropy Secret 1200b76 docker/configs/config-web-dc1.yaml View secret
6008657 Triggered Generic High Entropy Secret 1200b76 quality/integration/src/test/resources/config-all-role.yaml View secret
6008657 Triggered Generic High Entropy Secret 1200b76 web-local/config-local-main-role.yaml View secret
6008657 Triggered Generic High Entropy Secret 1200b76 web-local/config-dc2.yaml View secret
6008657 Triggered Generic High Entropy Secret 1200b76 web-local/config-megabus.yaml View secret
6008657 Triggered Generic High Entropy Secret 1200b76 web-local/config-local-dc1.yaml View secret
6008657 Triggered Generic High Entropy Secret 3ac6f61 docker/configs/config-web-dc1.yaml View secret
6008657 Triggered Generic High Entropy Secret 3ac6f61 docker/configs/config-web-dc2.yaml View secret
6008657 Triggered Generic High Entropy Secret 3ac6f61 docker/configs/config-stash-dc1.yaml View secret
6008657 Triggered Generic High Entropy Secret 3ac6f61 web-local/config-dc2.yaml View secret
6008657 Triggered Generic High Entropy Secret 3ac6f61 docker/configs/config-megabus-dc2.yaml View secret
6008657 Triggered Generic High Entropy Secret 3ac6f61 quality/integration/src/test/resources/config-all-role.yaml View secret
6008657 Triggered Generic High Entropy Secret 3ac6f61 docker/configs/config-megabus-dc1.yaml View secret
6008657 Triggered Generic High Entropy Secret 3ac6f61 web-local/config-local-dc1.yaml View secret
6008657 Triggered Generic High Entropy Secret 3ac6f61 web-local/config-megabus.yaml View secret
6008657 Triggered Generic High Entropy Secret 3ac6f61 web-local/config-jenkins.yaml View secret
6008657 Triggered Generic High Entropy Secret 3ac6f61 web-local/config-local-main-role.yaml View secret
6008657 Triggered Generic High Entropy Secret 3ac6f61 docker/configs/config-stash-dc2.yaml View secret
6008657 Triggered Generic High Entropy Secret 3ac6f61 web-local/config-local.yaml View secret
6008657 Triggered Generic High Entropy Secret 3ac6f61 sdk/src/main/resources/emodb-default-config.yaml View secret
6008657 Triggered Generic High Entropy Secret 3ac6f61 web-local/config-scantest.yaml View secret
6008657 Triggered Generic High Entropy Secret 3ac6f61 web-local/config-local-blob-role.yaml View secret
6008657 Triggered Generic High Entropy Secret 3ac6f61 web-local/config-local-2.yaml View secret
6008657 Triggered Generic High Entropy Secret 3ac6f61 web-local/config-web.yaml View secret
6008657 Triggered Generic High Entropy Secret 3ac6f61 quality/integration/src/test/resources/config-stash-role.yaml View secret
🛠 Guidelines to remediate hardcoded secrets

⚠️**NOTE: GitGuardian has been fully implemented by the Security team. Please carefully review all secrets found by this Pull Request check. Access to the GitGuardian UI is via the tile in Okta (which may need requested via HelpDesk if not visible). If you cannot see results for this GitHub repository then please reach out via the #secrets-management Slack channel.**⚠️


  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants