Add a mechanism to provide a list of protocol names for constant value extraction. #1170
Conversation
BalestraPatrick
force-pushed
the
constant-value-extraction
branch
3 times, most recently
from
cbf792b
to
a3529d0
Compare
|
what's the general progress on this? |
|
I just verified this seems to be working in our project together with bazelbuild/rules_apple#2418 |
BalestraPatrick
requested review from
brentleyjones,
luispadron,
mattrobmattrob and
thii
as code owners
swift/internal/compiling.bzl
Outdated
| @@ -3038,6 +3086,9 @@ def _declare_compile_outputs( | |||
| src = srcs[0], | |||
| )] | |||
| other_outputs = [] | |||
| const_values_files = [ | |||
There was a problem hiding this comment.
how much of this is from upstream? i don't see offhand why this is an array as opposed to a single file like some of the others, do you?
There was a problem hiding this comment.
Isn't it because there's one file per source file if it's not using wmo (specified in the for loop below here)?
BalestraPatrick
force-pushed
the
constant-value-extraction
branch
5 times, most recently
from
ddafafa
to
7c593f3
Compare
…e extraction. If a module populates `const_gather_protocols` when calling `create_swift_module_context`, any target that directly depends on that module will automatically have that list of protocols passed to the compiler via `-const-gather-protocols-file`. The output group `const_values` will then contain the JSON file with the extracted constant information. This is meant to support Apple's AppIntents framework, which uses the output from `-emit-const-values-path` as an input to the AppIntent bundling tool. PiperOrigin-RevId: 588388131 (cherry picked from commit 18f2f87) # Conflicts: # swift/internal/compiling.bzl # swift/internal/output_groups.bzl # swift/providers.bzl # swift/toolchains/config/compile_config.bzl # test/rules/provider_test.bzl # tools/worker/swift_runner.cc
BalestraPatrick
force-pushed
the
constant-value-extraction
branch
from
b179ff3
to
cc6abe8
Compare
|
@keith There were no tests upstream, but I tried my best at adding some. I also had to disable them on Linux due to the fact that we're using Swift 5.7 there, and from what I can see support for the flags we're using started in Swift 5.8. |
|
When testing this internally with a remote cache I'm getting Edit: removing our usage of |
This cherry-picks support for producing const values produced via the compiler flags
-emit-const-values-pathand-const-gather-protocols-file. rules_apple will start using this feature in bazelbuild/rules_apple#2418.