Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two command-line tools: oauth-generate-signature and oauth-generate-header #29

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jdormit
Copy link

@jdormit jdormit commented Sep 15, 2016

This adds two command-line tools, generate-oauth-signature and generate-oauth-header. It also adds documentation on both in the README. They do pretty much what you'd expect, both writing their output to stdout. Two new dependencies are introduced: commander.js to handle option and argument parsing and chalk to handle colored terminal output.

@jdormit jdormit changed the title This adds two command-line tools, generate-oauth-signature and generate-oauth-header. Two command-line tools: oauth-generate-signature and oauth-generate-header Sep 15, 2016
@bettiolo
Copy link
Owner

Thank you very much for the PR!

It would be great if you could add some tests as well.
Would you be able to do so?

The documentation looks great!

@jdormit
Copy link
Author

jdormit commented Sep 15, 2016

Sure thing - I won't be able to until sometime next week, but as soon as I do I'll let you know.

@ronkorving
Copy link

Nice addition! I think it would be pretty cool to add a (verbose) -v to generate-oauth-signature that would also output the base string, etc, so it can be used as a debugging tool to compare against other solutions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants