PaginatedListView changes and minor bug fix to an error message #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 1, 2010 10:45
…s an option. This way the default date based list views can be paginated as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main thing here is that I moved the functionality of PaginatedListView to ListView as I don't see a reason for these to be separate. The PaginatedListView, when paginate_by is set to None or 0 would act just like a ListView anyway.
The pagination for the ListView is optional. Only when paginate_by is set to something other than None or 0, will it be paginated.
The other commit was a minor issue when raising a Http404 error, it would return
django.utils.functional.lazy.__proxy__instead of the model'sverbose_name_pluralwhenverbose_name_pluralisn't specified in the_metaclass.