Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow disabling success toastr when adding the attachment with showAttachmentsToastr prop #1101

Closed
sritabh opened this issue May 21, 2024 · 1 comment · Fixed by #1104
Closed

Allow disabling success toastr when adding the attachment with showAttachmentsToastr prop #1101

sritabh opened this issue May 21, 2024 · 1 comment · Fixed by #1104
Assignees
@AbhayVAshokan
Labels
enhancement Enhancement or feature request. PR The issue has a PR associated with it. small Estimate - less than 2 hours

Comments

@sritabh
Copy link
Contributor

sritabh commented May 21, 2024

Currently the prop showAttachmentsToastr only modifies the visibility of toastr associated with api action update and delete.

We need to be able to disable the THUMBS_UP toast shown while adding a new attachment ref: https://github.com/bigbinary/neeto-desk-web/issues/19451
@sritabh sritabh added the enhancement Enhancement or feature request. label May 21, 2024
@AbhayVAshokan
Copy link
Member

I do not think we need Toastrs for attachments during creation or deletion. I am permanently removing the toasters instead.

@AbhayVAshokan _a
small _t

@neetogit-bot neetogit-bot bot added small Estimate - less than 2 hours working A branch associated with this issue is created. labels May 22, 2024
@AbhayVAshokan AbhayVAshokan mentioned this issue May 22, 2024
Merged
4 tasks
@neetogit-bot neetogit-bot bot added the PR The issue has a PR associated with it. label May 22, 2024
@neetogit-bot neetogit-bot bot removed the working A branch associated with this issue is created. label May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AbhayVAshokan AbhayVAshokan

Labels
enhancement Enhancement or feature request. PR The issue has a PR associated with it. small Estimate - less than 2 hours
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removed Toastrs from Attachments bigbinary/neeto-editor
2 participants
@AbhayVAshokan @sritabh