Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed Toastrs from Attachments #1104

Merged
merged 2 commits into from
May 22, 2024
Merged

Removed Toastrs from Attachments #1104

merged 2 commits into from
May 22, 2024

Conversation

AbhayVAshokan
Copy link
Member

Description

  • Removed Toastrs from Attachments.
  • Removed the showAttachmentsToastr prop.
  • Fixed issues with rename and added a loader for better UX.

Checklist

  • I have made corresponding changes to the documentation.
  • I have updated the types definition of modified exports.
  • I have verified the functionality in some of the neeto web-apps.
  • I have added the necessary label (patch/minor/major - If package publish
    is required).

Reviewers

minor _t
@AbhayVAshokan _a

@neetogit-bot neetogit-bot bot added the minor Releases non-breaking noteworthy changes with backward compatible. label May 22, 2024
@neetodeploy neetodeploy bot requested a deployment to neeto-editor-ou1t-pr-1104 May 22, 2024 14:46 In progress
@AbhayVAshokan AbhayVAshokan merged commit 334e796 into main May 22, 2024
@AbhayVAshokan AbhayVAshokan deleted the 1101-remove-showattachmentstoastr-prop branch May 22, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@AbhayVAshokan AbhayVAshokan

Labels
minor Releases non-breaking noteworthy changes with backward compatible.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow disabling success toastr when adding the attachment with showAttachmentsToastr prop
1 participant
@AbhayVAshokan