Skip to content

Commit

Permalink
Wrap the hidden searchlogic fields into a <div> container.
Browse files Browse the repository at this point in the history
XHTML strict doesn't allow <input> fields after <form> without a
surrounding container tag.

Signed-off-by: Ben Johnson <bjohnson@binarylogic.com>
  • Loading branch information
bernd authored and binarylogic committed Jan 6, 2009
1 parent de6f5b6 commit fdcf932
Showing 1 changed file with 8 additions and 7 deletions.
15 changes: 8 additions & 7 deletions lib/searchlogic/helpers/form.rb
Expand Up @@ -121,15 +121,16 @@ def insert_searchlogic_fields(args, search_object, search_options, &block)
return unless search_object.is_a?(Search::Base)
name = args.first
options = args.extract_options!
html = ""
search_options[:hidden_fields].each do |field|
html = hidden_field(name, field, :object => search_object, :id => "#{name}_#{field}_#{options.object_id}", :value => (field == :order_by ? searchlogic_base64_value(search_object.order_by) : search_object.send(field)))
html << hidden_field(name, field, :object => search_object, :id => "#{name}_#{field}_#{options.object_id}", :value => (field == :order_by ? searchlogic_base64_value(search_object.order_by) : search_object.send(field)))
end

# For edge rails and older version compatibility, passing a binding to concat was deprecated
begin
concat(html)
rescue ArgumentError, NameError
concat(html, block.binding)
end
# For edge rails and older version compatibility, passing a binding to concat was deprecated
begin
concat(content_tag(:div, html, :style => 'margin:0;padding:0'))
rescue ArgumentError, NameError
concat(content_tag(:div, html, :style => 'margin:0;padding:0'), block.binding)
end
args << options
end
Expand Down

0 comments on commit fdcf932

Please sign in to comment.