Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check sandbox_dir instead of mktemp #154

Merged
merged 2 commits into from
May 28, 2024
Merged

check sandbox_dir instead of mktemp #154

merged 2 commits into from
May 28, 2024

Conversation

ezrizhu
Copy link
Collaborator

@ezrizhu ezrizhu commented Mar 30, 2024 •
edited

fix bug where we're checking overlayfs (for docker) on a mktemp -d instead of SANDBOX_DIR (if specified)

log to try_mount_log if we're using tmpfs due to overlayfs

  • doc to mention -v trick for tmp

@ezrizhu ezrizhu requested a review from mgree March 30, 2024 22:19
@ezrizhu ezrizhu self-assigned this Mar 30, 2024
@ezrizhu ezrizhu marked this pull request as ready for review March 31, 2024 05:09
mgree
mgree approved these changes Apr 1, 2024
View reviewed changes
Copy link
Contributor

@mgree mgree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit; lgtm!

try Outdated Show resolved Hide resolved
@ezrizhu ezrizhu merged commit cbad35f into main May 28, 2024
17 checks passed
@ezrizhu ezrizhu deleted the ezri/docker-fix branch May 28, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgree mgree mgree approved these changes

Assignees

@ezrizhu ezrizhu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ezrizhu @mgree