biome-ignore for multiple lines

[yphoenix]

There are places where we just need to turn biome off for a routine or section of lines. Turning it off for a single line is great (ESLint has this), but it would be great to turn it off / on for a bunch of lines, eg:

// biome-rule-off
// biome-rule-on

Or some variation of the above

[k-utsumi]

NOTE: Prettier only support Markdown

• Support prettier-ignore-start/end for other languages (not only Markdown) prettier/prettier#5287
  • My hack comment

---

ESLint supports that.

/* eslint-disable */

alert('foo');

/* eslint-enable */

—— REF (Configure Rules - ESLint)

We want to use it too 🙏

[ematipico]

I don't think we will support this kind of suppression system

[ematipico]

I am sure there's a use case for this kind of suppression system. However, I find complex and prone to errors. Plus, users might expect to use this suppression system for the formatter too.

This could be a pretext to add inline configuration, which is also supported in Eslint, and I find it complex.

I checked if other linters support this suppression system , I couldn't find any. I checked ruff, clippy and elm-review.

[yphoenix]

eslint does (obviously).
jshint does
stylelint does, in the same kind of way that eslint does
I think csslint did, but everyone uses stylelint nowadays anyway

It a common thing for linters to be able to turn rules on and off for more than a single line.

Plus, users might expect to use this suppression system for the formatter too.

Yes, they might, and would probably find that useful too now that you mention it.

[sassomedia]

@ematipico Can we add this please? I don't understand why this is in question.

Server data won't conform to front end conventions, there need be multi-line exceptions made.

{
  body: {
    data: {
      // biome-ignore lint/style/useNamingConvention: API props
      advertiser_id: 213609,
      budget: 2.46,
      // biome-ignore lint/style/useNamingConvention: API props
      campaign_name: "Submit kt test 89 upd",
      // biome-ignore lint/style/useNamingConvention: API props
      currency_code: "USD",
      // biome-ignore lint/style/useNamingConvention: API props
      end_date: "2020-12-14 22:55",
      // biome-ignore lint/style/useNamingConvention: API props
      frequency_amount: 0,
      // biome-ignore lint/style/useNamingConvention: API props
      frequency_interval: "not-applicable",
      // biome-ignore lint/style/useNamingConvention: API props
      frequency_optimization: false,
      // biome-ignore lint/style/useNamingConvention: API props
      frequency_type: "no-limit",
      // biome-ignore lint/style/useNamingConvention: API props
      goal_type: "vcr",
      // biome-ignore lint/style/useNamingConvention: API props
      goal_value: 100,
      id: 862881,
      // biome-ignore lint/style/useNamingConvention: API props
      spend_cap_amount: 0.0,
      // biome-ignore lint/style/useNamingConvention: API props
      spend_cap_automatic: false,
      // biome-ignore lint/style/useNamingConvention: API props
      spend_cap_type: "no-limit",
      // biome-ignore lint/style/useNamingConvention: API props
      start_date: "2020-12-14 21:55",
      status: false,
      // biome-ignore lint/style/useNamingConvention: API props
      time_zone: "Europe/London",
      type: "FAN/PMP/OPEN",
    },
    meta: { status: "ok" },
  },
}

[Conaclos]

@ematipico This could be solved by using naming convention options #1900

[sassomedia]

@Conaclos I appreciate you looking into this but the code above is merely an example. There can be various use-cases (aside from naming) where rules need to be disabled for multiple lines or blocks of code. A single line is insufficient and file-based disabling is too much if it should only affect a limited scope.

Since multi-line ignore is supported in both ESLint and Prettier, it is difficult to transition code bases to Biome without that. This is quite an essential feature. Please consider adding it. 🙏

[k-utsumi]

I want to use it in cases like this.

example

const theme = {
	colors: {
		// biome-ignore format:
		primary:   '#000',
		secondary: '#000',

		success: '#000',
		info: '#000',
		warning: '#000',
		error: '#000',


		tokens: {
			// ...
		},
	},
}

If it's not acceptable,
I'll probably write a hack code.

example

const theme = {
	colors: {
		// biome-ignore format:
		...{
			primary:   '#000',
			secondary: '#000',

			success: '#000',
			info:    '#000',
			warning: '#000',
			error:   '#000',
		},

		tokens: {
			// ...
		},
	},
}