Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] SolidJS Components return once #2439

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

marvin-j97
Copy link
Contributor

@marvin-j97 marvin-j97 commented Apr 13, 2024

Summary

Implement part of #2438

Source: https://github.com/solidjs-community/eslint-plugin-solid/blob/main/docs/components-return-once.md

Test Plan

There are generally three cases this lint rule needs to cover:

  • ternary returns
  • short-circuit returns (&&, ||)
  • if-else returns (early returns)

Right now I only have implemented ternaries.

@github-actions github-actions bot added A-Project Area: project A-Linter Area: linter L-JavaScript Language: JavaScript and super languages A-Diagnostic Area: diagnostocis labels Apr 13, 2024
Copy link

netlify bot commented Apr 13, 2024

Deploy Preview for biomejs ready!

Name Link
🔨 Latest commit 30bef0d
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/661ac61ed613c400087078f3
😎 Deploy Preview https://deploy-preview-2439--biomejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (🟢 up 1 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the A-Website Area: website label Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Diagnostic Area: diagnostocis A-Linter Area: linter A-Project Area: project A-Website Area: website L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant