feat(biome_js_analyze): noTsIgnoreComment add initial rule

[emab]

Summary

Implements noTsIgnoreComment rule, which prevents the use of @ts-ignore.

• 📎 Implement nursery/noTsComment - typescript-eslint/ban-ts-comment #713

Test Plan

TBC

[emab]

Bit of a work in progress.

Not sure if I should include an action to remove the comment, or replace with ts-expect-error.

[codspeed-hq]

CodSpeed Performance Report

Merging #2576 will not alter performance

_{Comparing emab:feat/noTsIgnoreComment (c884063) with main (7ea5dff)}

Summary

✅ 84 untouched benchmarks

[emab]

I'm guessing the performance hit is due to using AnyJsModuleItem?

I wasn't sure how to directly find only comment stings. Should I be using the semantic model instead?

[ematipico]

I'm guessing the performance hit is due to using AnyJsModuleItem?

It's a false positive, don't worry

[ematipico]

I wasn't sure how to directly find only comment stings. Should I be using the semantic model instead?

No. You only need to query the CST, comments are trivia and they have no part in the semantic model.

However, you have to widen the query. Comments can be anywhere! Technically, you'd need to query any node

[emab]

No. You only need to query the CST, comments are trivia and they have no part in the semantic model.

Okay cool, I thought that was the case!

However, you have to widen the query. Comments can be anywhere! Technically, you'd need to query any node

Ah so right now I'll be missing comments within module items I suppose?

I was hoping I'd be able to match on a comment line, but since it's trivia I assume I'll need to search for any node and collect matching ts ignore trivia's?

[ematipico]

I was hoping I'd be able to match on a comment line, but since it's trivia I assume I'll need to search for any node and collect matching ts ignore trivia's?

Yeah, that's right. There was this old initial implementation that you could use as a source of inspiration: https://github.com/rome/tools/pull/2811/files
Be mindful that the PR was closed, which means that some cases weren't caught. Also, as a piece of personal advice, I would avoid a code action for now. Working with trivia and mutations can be tricky.

[emab]

Yeah, that's right. There was this old initial implementation that you could use as a source of inspiration: https://github.com/rome/tools/pull/2811/files Be mindful that the PR was closed, which means that some cases weren't caught. Also, as a piece of personal advice, I would avoid a code action for now. Working with trivia and mutations can be tricky.

Thanks for sharing that. I guess my question now is - are the performance issues mentioned now no longer a problem?

Also:

ability for lint rules (and visitors) to inspect syntax tokens (currently lint rules can only query AST nodes)

Am I correct in thinking we can now query syntax tokens? Should I be querying these in order to catch the edge cases? Quite new to this world so apologies if these are simple questions!

[adriencaccia]

I'm guessing the performance hit is due to using AnyJsModuleItem?

It's a false positive, don't worry

Hey @ematipico, we released a feature to ignore benchmarks that have a tendency to be flaky.
You can ignore the benchmark big5-added.json[uncached] on its dashboard page.

This is not ideal, but sometimes the code used in some benchmarks is by definition not deterministic, so removing them from the report is preferable to avoid noise. Ignored benchmarks are still measured at every run though, and their history can still be accessed on CodSpeed 😉
The more ignored benchmarks we have, the more data we will have to work on automatically identifying flaky code, so that in the future we will remove this kind of noise.

Let me know if that works for you!

[ematipico]

Hey @adriencaccia! That's an amazing feature, thank you for implementing that, I will start ignoring flaky benchmarks now :)

[ematipico]

Am I correct in thinking we can now query syntax tokens? Should I be querying these in order to catch the edge cases? Quite new to this world so apologies if these are simple questions!

You can give it a try, let's see how it goes!