feat(biome_css_analyzer): noDuplicateCustomProperties
#2783
Conversation
github-actions
bot
added
A-Project
CodSpeed Performance ReportMerging #2783 will not alter performanceComparing Summary
|
chansuke
force-pushed
the
feat/declaration-block-no-duplicate-custom-properties
branch
from
8cb3658
to
eebb582
Compare
| let mut custom_properties: Vec<SyntaxToken<CssLanguage>> = vec![]; | ||
| for item in node { | ||
| if let Some(css_declaration) = item.as_css_declaration_with_semicolon() { | ||
| if let Ok(property) = css_declaration.declaration().ok()?.property() { | ||
| if let Some(property) = property.as_css_generic_property() { | ||
| if let Some(ident) = property.name().ok()?.as_css_identifier() { | ||
| let value_token = ident.value_token().ok()?; | ||
| custom_properties.push(value_token); | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Opinion: I think you can get rid of the mut here by using a filter_map and it will return an Iterator that you can possible use directly with check_duplicate_custom_properties.
| let mut custom_properties: Vec<SyntaxToken<CssLanguage>> = vec![]; | |
| for item in node { | |
| if let Some(css_declaration) = item.as_css_declaration_with_semicolon() { | |
| if let Ok(property) = css_declaration.declaration().ok()?.property() { | |
| if let Some(property) = property.as_css_generic_property() { | |
| if let Some(ident) = property.name().ok()?.as_css_identifier() { | |
| let value_token = ident.value_token().ok()?; | |
| custom_properties.push(value_token); | |
| } | |
| } | |
| } | |
| } | |
| } | |
| let custom_properties = node.into_iter().filter_map(|item| { | |
| item.as_css_declaration_with_semicolon() | |
| .and_then(|css_declaration| { | |
| css_declaration | |
| .declaration() | |
| .ok()? | |
| .property() | |
| .ok()? | |
| .as_css_generic_property() | |
| .and_then(|css_generic_property| { | |
| css_generic_property | |
| .name() | |
| .ok()? | |
| .as_css_identifier() | |
| .and_then(|css_identifier| css_identifier.value_token().ok()) | |
| }) | |
| }) | |
| }); |
You don't need to use it like above, as long as you are returning an Option (Some/None) it should be okay!
There was a problem hiding this comment.
@abidjappie
I appreciate so much for your feedback!! That's clean and readable.
|
I wonder if we should start writing a semantic model. I think this rule would benefit from it |
|
@ematipico |
Sure, I suggest talking with @togami2864, I know he has plans about it |
Summary
Fixes #2784
Test Plan