Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow wallet file to be a symlink, as was the case before v0.15.0 #12228

Closed
wants to merge 1 commit into from

Conversation

mmgen
Copy link

@mmgen mmgen commented Jan 19, 2018

No description provided.

@jnewbery
Copy link
Contributor

NACK. Please see discussion here: #10885 (comment) for why this unintended behaviour was removed.

In general, PRs without a description are unlikely to get much sympathy/review.

If you need flexibility in where your wallet files are kept, you may wish to help with reviewing #11687

@ryanofsky
Copy link
Contributor

ryanofsky commented Jan 19, 2018

I don't think we can do this because of concerns that storing the berkeleydb data file separately from berkeleydb log files (in database/log.*) could lead to data and funds loss. With 0.16 it will be possible to specify a -walletdir= option to bitcoind that can be a symlink. Also #11687, which is not scheduled to be merged before 0.16 is branched, will restore the option for individual wallets to be symlinks (to directories).

@maflcko
Copy link
Member

maflcko commented Jan 19, 2018

With 0.16 it will be possible to specify a -walletdir= option to bitcoind that can be a symlink.

I'd suggest to close this pull, then.

@maflcko maflcko added the Wallet label Jan 19, 2018
@mmgen
Copy link
Author

mmgen commented Jan 19, 2018

With 0.16 it will be possible to specify a -walletdir= option to bitcoind that can be a symlink.

Fine, this answers my needs (just compiled from master and tried it out) and is actually a much better solution than the symlink. Closing the PR. Thanks all for the helpful information.

@mmgen mmgen closed this Jan 19, 2018
@mmgen mmgen deleted the wallet_symlink branch January 20, 2018 08:25
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants